Gideon Bature comments

Results 9 comments of


                                            Gideon Bature

test for excluded bounds in outputs_in_range

tACK #1897 Tested and working as it should.

Enforce content-length validation on sender and size limits on payjoin-cli

I have implemented the changes suggested. However, I had to introduce about two dependencies, which are: - futures - bytes as a result of that I attempted to update the...

Enforce content-length validation on sender and size limits on payjoin-cli

I implemented the suggestions you gave, however, for the utility function, putting it in `mod.rs` of `app`, I am encountering a challenge where I am unable to access the `hyper`...

Enforce content-length validation on sender and size limits on payjoin-cli

> I didn't quite understand your last comment about hyper & bytes, but i think the `read_limited_body` function is in the right place? > > similar limiting for `app/v2.rs` can...

Enforce content-length validation on sender and size limits on payjoin-cli

This PR addresses the hyper crate issue and also all the suggestions given. Thank you.

Enforce content-length validation on sender and size limits on payjoin-cli

Resolved merge conflicts.

Enforce content-length validation on sender and size limits on payjoin-cli

Lint is failing with this: ```rust error[E0599]: no variant or associated item named `Parse` found for enum `core::send::error::InternalValidationError` in the current scope --> payjoin/src/core/send/mod.rs:699:90 | 699 | let res_str =...

Enforce content-length validation on sender and size limits on payjoin-cli

Resolved merge conflict.

Refactor: move `mopro-wasm` to `mopro-ffi` and update the CLI

Can you please assign me this task? I will love to work on it. Recommended by [OnlyDust](https://onlydust.com/) for exceptional experience, quality, and reliability.