bdk icon indicating copy to clipboard operation
bdk copied to clipboard
verified publisher icon bitcoindevkit

test for excluded bounds in outputs_in_range

Open aagbotemi opened this issue 10 months ago • 5 comments

Description

This PR covers a wide range on tests for excluded bounds and the SpkTxOutIndex::outputs_in_range. This PR fixes bitcoindevkit/bdk_wallet#58

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • [x] I've signed all my commits
  • [x] I followed the contribution guidelines
  • [x] I ran cargo fmt and cargo clippy before committing

New Features:

  • [ ] I've added tests for the new feature
  • [ ] I've added docs for the new feature

Bugfixes:

  • [ ] This pull request breaks the existing API
  • [ ] I've added tests to reproduce the issue which are now passing
  • [x] I'm linking the issue being fixed by this PR

aagbotemi avatar Mar 18 '25 01:03 aagbotemi

tACK #1897

Tested and working as it should.

GideonBature avatar Apr 26 '25 13:04 GideonBature

@aagbotemi If you plan to rebase I left a comment that I think would make the test better.

@ValuedMammal I have rebased and attended to the comment. Thank you.

aagbotemi avatar Jun 10 '25 00:06 aagbotemi

ACK 8a86594ef5f33502329ba94ff6dcbbd6d040a9b5 pending a passing CI run.

ValuedMammal avatar Jun 11 '25 23:06 ValuedMammal

ACK 8a86594 pending a passing CI run.

@ValuedMammal I have rebased with PR #1972, that will fix the CI as discussed

aagbotemi avatar Jun 13 '25 17:06 aagbotemi

Just needs a rebase to pick up a CI change and then it looks ready to merge.

Thank you for the feedback. I have rebased

aagbotemi avatar Jun 17 '25 22:06 aagbotemi

ACK ad792670c487e62183d901338b2655ec7b81c688

ValuedMammal avatar Jul 03 '25 13:07 ValuedMammal