Francis O'Brien

Results 13 comments of Francis O'Brien

Just another note on this. If the address is whitelisted on the attached external whitelist but the issuer does not have access to edit it, or if they wish to...

> @F-OBrien This is an impressive start! Thanks for pushing this. > > I have left a couple of comments and the other thing I'd like you to do is...

Thanks for reviewing. I've moved the files and I'll try to work through some of the other comments this evening if I get time.

Ok, so I think you are saying the Polkadot browser extension and the extension-dapp package need to be running a version with the fix for unsubs to work? (I believe...

I just updated to v3 and now have issues with many links generated by typdoc. The broken link pattern is similar to that reported by @bo-carey. in the below Link2...

That's disappointing. Well it seems to work with Chrome at least if you wanted to consider it as a slight improvement over the current implementation.

@ty-zyp 1. This is by design. Signing accounts must be unassigned and do not hold funds. Signing identities are independent identities. The multisig itself must be attached to an identity...

Further to the above if the header is simply renamed it seems to give the correct error message. The column header error shift seems to only happen when columns are...

Ok I believe the issue may be that excel adds a carriage return where there would only have been a new line (LF) with the original file. this possibly explains...

I believe changing this line https://github.com/PolymathNetwork/polymath-apps/blob/2ba08cc912d6eb7834df19dcd39be4eb93a0fda0/packages/polymath-issuer/src/utils/parsers/index.js#L73 to ` let rows = data.split(/\r\n|\r|\n/);` or `let rows = data.split(/\r?\n/);` should resolve this issue and allow imports of csv files edited on both...