PolymathNetwork
Issue with Whitelist header Row checks
The whitelist header row checks appear to be shifted by one.
For example if you take the template whitelist and simply delete the "is Accredited" and "Non-Accredited Limit" columns you get an error per below. As these columns are not required unless the Pegged STO is attached this should not result in an error.
If you delete the Exempt from "Exempt From % Ownership" column you get
delete the "Can Buy From STO" column you get
Further to the above if the header is simply renamed it seems to give the correct error message. The column header error shift seems to only happen when columns are completely deleted. I've attached the whitelist file that gives me this error in case it has some how it become incorrectly formatted by simply opening in excel deleting the last two columns and saving.
Ok I believe the issue may be that excel adds a carriage return where there would only have been a new line (LF) with the original file. this possibly explains why I've had errors reported by the last line of whitelists edited in excel also. If this is the case it should be handled or some clear guidance should be provided to issuers about editing the .csv file to ensure it remains functional.
Original
After Edit in Excel
I believe changing this line https://github.com/PolymathNetwork/polymath-apps/blob/2ba08cc912d6eb7834df19dcd39be4eb93a0fda0/packages/polymath-issuer/src/utils/parsers/index.js#L73
to let rows = data.split(/\r\n|\r|\n/); or let rows = data.split(/\r?\n/); should resolve this issue and allow imports of csv files edited on both Windows and UNIX systems