Emad

Results 4 comments of Emad

> > There is quite a few things reported in sonarcloud. I don't think everything needs to be addressed but some definitely should like the unused variable and shadow variable...

> ## [![Quality Gate Passed](https://camo.githubusercontent.com/5889b9ad78888934928f8f18bb6431c836cd7cabe6c3a6a60a1a01434d67cfdb/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636865636b732f5175616c6974794761746542616467652f71672d7061737365642d323070782e706e67)](https://sonarcloud.io/dashboard?id=hyperledger_aries-cloudagent-python&pullRequest=2960) **Quality Gate passed** > Issues ![](https://camo.githubusercontent.com/da77210611fad32e47ac6a36190d5e5320fe19b1c6006fae418d539fadaadc93/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67) [12 New issues](https://sonarcloud.io/project/issues?id=hyperledger_aries-cloudagent-python&pullRequest=2960&resolved=false&sinceLeakPeriod=true) ![](https://camo.githubusercontent.com/6e7f22e3d7f9764d9cfb28e3b8ee5ebb5f711c5bb2dcec8a6db6b0d958d63134/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f61636365707465642d313670782e706e67) [0 Accepted issues](https://sonarcloud.io/project/issues?id=hyperledger_aries-cloudagent-python&pullRequest=2960&resolutions=WONTFIX) > > Measures ![](https://camo.githubusercontent.com/da77210611fad32e47ac6a36190d5e5320fe19b1c6006fae418d539fadaadc93/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=hyperledger_aries-cloudagent-python&pullRequest=2960&resolved=false&sinceLeakPeriod=true) ![](https://camo.githubusercontent.com/da77210611fad32e47ac6a36190d5e5320fe19b1c6006fae418d539fadaadc93/68747470733a2f2f736f6e6172736f757263652e6769746875622e696f2f736f6e6172636c6f75642d6769746875622d7374617469632d7265736f75726365732f76322f636f6d6d6f6e2f7061737365642d313670782e706e67) [86.4% Coverage on New...

Thanks for reviewing, im editing it and i will push asap

> @EmadAnwer the coverage test is still failing on the `VCDICredFormatHandler` class (in `formats/vc_di/handler.py`). > > There are a couple of unit tests already that are marked as "skipped" (since...