aries-cloudagent-python [WIP] feat: VC DI proof request

May 21 '24 18:05 sarthakvijayvergiya

Quality Gate passed

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

May 21 '24 18:05 sonarqubecloud[bot]

I know this is still WIP, but we need to have a description on the PR (is necessary in case anyone needs to look back on this PR in the future, and is also used for release notes). Also it's good - if the PR is in WIP state - to make a note of what is done and what's still outstanding ...

Jun 04 '24 17:06 ianco

Also just noticed the commit is missing the DCO signoff

Jun 16 '24 16:06 ianco

There is quite a few things reported in sonarcloud. I don't think everything needs to be addressed but some definitely should like the unused variable and shadow variable names.

https://sonarcloud.io/project/issues?id=hyperledger_aries-cloudagent-python&pullRequest=2960&resolved=false&sinceLeakPeriod=true

Maybe have a go over and see if we can make some improvements. I think overall the code looks good and well tested.

Jul 11 '24 23:07 jamshale

There is quite a few things reported in sonarcloud. I don't think everything needs to be addressed but some definitely should like the unused variable and shadow variable names.

https://sonarcloud.io/project/issues?id=hyperledger_aries-cloudagent-python&pullRequest=2960&resolved=false&sinceLeakPeriod=true

Maybe have a go over and see if we can make some improvements. I think overall the code looks good and well tested.

Good catch @jamshale

@EmadAnwer can you review the SonarCloud report and do a bit of cleanup? As Jamie says we don't need to address everything but take a pass and see what you think.

Jul 11 '24 23:07 ianco

There is quite a few things reported in sonarcloud. I don't think everything needs to be addressed but some definitely should like the unused variable and shadow variable names. https://sonarcloud.io/project/issues?id=hyperledger_aries-cloudagent-python&pullRequest=2960&resolved=false&sinceLeakPeriod=true Maybe have a go over and see if we can make some improvements. I think overall the code looks good and well tested.

Good catch @jamshale

@EmadAnwer can you review the SonarCloud report and do a bit of cleanup? As Jamie says we don't need to address everything but take a pass and see what you think.

yes sure

Jul 12 '24 05:07 EmadAnwer

Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Jul 12 '24 06:07 sonarqubecloud[bot]

Quality Gate passed

Issues 12 New issues 0 Accepted issues

Measures 0 Security Hotspots 86.4% Coverage on New Code 0.0% Duplication on New Code

See analysis details on SonarCloud

There is quite a few things reported in sonarcloud. I don't think everything needs to be addressed but some definitely should like the unused variable and shadow variable names. https://sonarcloud.io/project/issues?id=hyperledger_aries-cloudagent-python&pullRequest=2960&resolved=false&sinceLeakPeriod=true Maybe have a go over and see if we can make some improvements. I think overall the code looks good and well tested.

Good catch @jamshale @EmadAnwer can you review the SonarCloud report and do a bit of cleanup? As Jamie says we don't need to address everything but take a pass and see what you think.

yes sure

@jamshale @ianco I have fixed most of it, check it please, let me know if there are any suggestions

Jul 12 '24 07:07 EmadAnwer

I'm going to merge this. Would be nice to have in the 1.0.0 release and don't predict any regressions.

Jul 12 '24 15:07 jamshale

w00t!!! Awesome.

Jul 12 '24 15:07 swcurran