Ed Caunt
Ed Caunt
Can we resurrect this? It fixes an issue which still exists (I accidentally replicated the fix in #2357)
This was also found to affect substitutions at forward and backward time steps (although this may have been fixed since?). However, a new MFE is: ``` import numpy as np...
Create a `ConditionalDimension` with a condition but no factor, then compare `cd._factor` to `cd._rebuild()._factor`
Are these install issues with GemPy still outstanding? Other people have reported that the notebook was running smoothly again relatively recently, although it still needs some tidy up to reflect...
> This needs bunch of tests including with MPI. Do we wanna define `union` as well? Tests to come. Union is more complex and less urgent so was going to...
We could always set a custom rule to ignore "line too long"
Looking at it, there are only about 5 "Line too long" warnings in the whole output, and most are only 5 or so characters over.
> This diff is way too big for just a few line change. Yeah, I messed up adding the changes in one of the notebooks somehow. Will fix in due...
> Also those depa should be in requirements-testing.txt not hardcoded in the yaml I was just going off how the Flake8 workflow already works, can change this
> do we now risk a proliferation of f.d(weights=weights, ...) in the PDE specification? The user can also do something like: ``` subs = {f.dx: f.dx(weights=weights0), f.dy: f.dy(weights=weights0), f.dx2: f.dx2(weights=weights1)}...