compiler: Fix placement of ConditionalDimension in subdomain

[georgebisbas]

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.75%. Comparing base (cafebc1) to head (c35a0c1).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2050      +/-   ##
==========================================
+ Coverage   86.73%   86.75%   +0.01%     
==========================================
  Files         233      233              
  Lines       43648    43707      +59     
  Branches     8077     8077              
==========================================
+ Hits        37859    37916      +57     
- Misses       5079     5080       +1     
- Partials      710      711       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[georgebisbas]

Do the new tests actually fail under master?

Yes, they fail in the current master with the python-land exception (I guess the same you think of here: https://devitocodes.slack.com/archives/C7JMLMSG0/p1674301184495359?thread_ts=1674231704.845469&cid=C7JMLMSG0)

[georgebisbas]

@FabioLuporini plans for this?

[FabioLuporini]

@georgebisbas plan imho is to find a neater/simpler/better way

[mloubout]

What's the status on this?

[georgebisbas]

@FabioLuporini requested a better solution on this. Any ides?

[mloubout]

As per my comment above, I don't think it's an issue anymore and should work without the change

[georgebisbas]

@mloubout I cannot see any comment of yours (?)

pytest tests/test_subdomains.py::TestSubDomain_w_condition

I tried to run the tests and they fail

[EdCaunt]

Can we resurrect this? It fixes an issue which still exists (I accidentally replicated the fix in #2357)