Jk Xu

Results 12 comments of Jk Xu

We can investigate how snowflake implement this (data unique constraint), and I have a question: is ART Tree suitable for object storage ?

Is ART Tree suitable for object storage ? I think this question is very important, because Databend is not a memory or disk oriented database.

> > We can investigate how snowflake implement this (data unique constraint), and I have a question: is ART Tree suitable for object storage ? > > for now, they...

> Is there any estimate on when this might get selected for development? @inviscid I am working on it and recursive cte.

@inviscid Thanks for your help, expect a PR within a week.

Hi @zenus , do you need some help ?

> @Dousir9 could you help me , i can not pass all the case, in my laptop, i passed all new test case. @zenus Yeah, I will review this PR...

@zenus Sorry for the wait, I was really busy, let's continue this excellent work. 1. For `test_asof_join_ints.test:65`, we can fix it by adding an order by column to this sqllogictest....

You can change the predicate to `test_time >= now()` to solve this issue, we will optimize this syntax in the future https://github.com/datafuselabs/databend/issues/15020.

It would be better to provide a rust benchmark to test the migrated functions in kernels(`take.rs, concat.rs, ...`) to ensure that there is no performance regression.