databend icon indicating copy to clipboard operation
databend copied to clipboard

refactor: migrage Bitmap from arrow2 to arrow-rs

Open andylokandy opened this issue 1 year ago โ€ข 1 comments

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • [x] Unit Test
  • [ ] Logic Test
  • [ ] Benchmark Test
  • [ ] No Test - Explain why

Type of change

  • [ ] Bug Fix (non-breaking change which fixes an issue)
  • [ ] New Feature (non-breaking change which adds functionality)
  • [ ] Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • [ ] Documentation Update
  • [x] Refactoring
  • [ ] Performance Improvement
  • [ ] Other (please describe):

This change isโ€‚Reviewable

andylokandy avatar Sep 25 '24 18:09 andylokandy

It would be better to provide a rust benchmark to test the migrated functions in kernels(take.rs, concat.rs, ...) to ensure that there is no performance regression.

Dousir9 avatar Sep 26 '24 06:09 Dousir9