DannyLi

Results 20 comments of DannyLi

This PR is from #506 . @SujeethJinesh These errors likely aren't related to my modifications. They seem to be primarily about IP conflicts and the inability to get-credentials for the...

@SujeethJinesh This issue likely stems from conflicts caused by the default network and IP. To pass the checks, we might need to include the creation of networks, subnetworks, firewalls, and...

@wstcliyu Might need to help Sujeeth discuss this with Piotr. Thanks!

> What is the exact reason for this PR? This is a task @SujeethJinesh assigned to me. Here are Sujeeth's objectives. https://b.corp.google.com/issues/423650971

> @SujeethJinesh This issue likely stems from conflicts caused by the default network and IP. To pass the checks, we might need to include the creation of networks, subnetworks, firewalls,...

@SujeethJinesh @pawloch00 Main task: https://b.corp.google.com/issues/423650971 The current problem is a conflict caused by the default network of the test environment and IP. The reason my manual tests had no issues...

@xibinliu and @Shuang-cnt please review it.

> Also, please merge the current main branch, because the PR changes are mixed with the sub-slicing changes, making it harder to review. When I run `git checkout -b`, should...

> 1. What's the justification for this change? Why are we adding this for every cluster? > 2. What's diagon? > 3. Could you cover the changes with unit tests...

> > > Also, please merge the current main branch, because the PR changes are mixed with the sub-slicing changes, making it harder to review. > > > > >...