xpk Feat: Added functionalities to remove duplicate parameters and overwrite existing ones.

Fixes / Features

Added functionality to delete conflicting parameters and overwrite duplicate ones, ensuring user-defined settings take precedence.

Testing / Documentation

Can be tested when creating a cluster using XPK.

[ y/n ] Tests pass
[ y/n ] Appropriate changes to documentation are included in the PR

Jul 11 '25 02:07 DannyLiCom

@sharabiani ptal

Jul 18 '25 10:07 pawloch00

This PR is from #506 . @SujeethJinesh These errors likely aren't related to my modifications. They seem to be primarily about IP conflicts and the inability to get-credentials for the cluster.

Jul 21 '25 05:07 DannyLiCom

The tests are failing and I don't think fault is on the tests side this time @DannyLiCom

Jul 22 '25 06:07 pawloch00

@SujeethJinesh This issue likely stems from conflicts caused by the default network and IP. To pass the checks, we might need to include the creation of networks, subnetworks, firewalls, and so on, and then change the defaults to the new network.(Refer to here) This would involve a lot of related changes and modifications.

Jul 23 '25 04:07 DannyLiCom

@wstcliyu Might need to help Sujeeth discuss this with Piotr. Thanks!

Jul 24 '25 07:07 DannyLiCom

What is the exact reason for this PR?

Jul 25 '25 08:07 pawloch00

What is the exact reason for this PR?

This is a task @SujeethJinesh assigned to me. Here are Sujeeth's objectives. https://b.corp.google.com/issues/423650971

Jul 28 '25 09:07 DannyLiCom

@SujeethJinesh This issue likely stems from conflicts caused by the default network and IP. To pass the checks, we might need to include the creation of networks, subnetworks, firewalls, and so on, and then change the defaults to the new network.(Refer to here) This would involve a lot of related changes and modifications.

@SujeethJinesh This issue still exists.

Aug 04 '25 06:08 DannyLiCom

@SujeethJinesh @pawloch00 Main task: https://b.corp.google.com/issues/423650971 The current problem is a conflict caused by the default network of the test environment and IP.

The reason my manual tests had no issues is that I would first create the network, subnetwork, firewall and so on as a prerequisite before running the test. https://screenshot.googleplex.com/4BGSx4yGJqz6Xdh Sources: https://docs.google.com/document/d/1gpcNDkqCgWAQYN_KOb7M5eiXd_bquSvLeKjA966LJbk/edit?tab=t.0#heading=h.glahk2wkse7w

But if I were to put the creation of networks, etc., inside the xpk code, it feels a bit illogical, and it would likely require a lot of modifications.

The solutions I can think of are to either change the original default network or, as we just discussed, to add a method for creating networks inside the code.

I might need some advice.

Aug 13 '25 08:08 DannyLiCom

This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Nov 28 '25 02:11 github-actions[bot]