DamianSawicki
DamianSawicki
> `Service` type in comparison to `SVC` has additional fields related to reconciliation status and backend revision (the link between the two tables). I believe `Service` should be `Frontend`. >...
I promised to cut a new tag this week. IIUC, all comments have been addressed, so if you are fine with responses @bowei , please lgtm by Thursday, and I'll...
I see Bowei's questions are from May and they were probably sent this week by mistake, and this week Bowei wrote /approve twice, so the intention seems clear and I...
/assign joamaki
> some minor comments. > > You may want to consider having two commits -- one move and another that does diffs. Thanks for review @bowei! I've split this into...
Please remove internal ticket numbers from commit descriptions. I also don't expect `Add a simple e2e test` to work in OSS, so this needs to be reworked or skipped.
> Who should I asked for approval to merge this review? Judging from > @[AwesomePatrol](https://github.com/AwesomePatrol) AwesomePatrol requested review from [jrajahalme](https://github.com/jrajahalme) (assigned from cilium/envoy) and [nebril](https://github.com/nebril) (assigned from cilium/contributing) [5 months...
/test all
Hi @dereknola, I think this repo desperately needs more maintainers. Currently no PR can be submitted (at least normally) because CI is broken (so there is little sense in reviewing...