kubernetes
Bump coredns and kubernetes dependencies
Background
These two dependencies are very Out of Date and are introducing CVEs into downstream repos. A previous PR was auto opened by dependabot, but never went anywhere. https://github.com/kubernetes/dns/pull/641 This PRs scope is more limited.
Changes
- Bump coredns to 1.11.3 (latest version)
- Bump K8s to 1.28.14 (the oldest version still being supported as of October 2024). This should ensure maximum compatibility.
- Migrate from deprecated clock package to replacement (clocks and clocks/testing got split up)
The go mod vendor has been isolated to a separate commit to make review easier.
Welcome @dereknola!
It looks like this is your first PR to kubernetes/dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes/dns has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @dereknola. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@DamianSawicki Can I get a review on this please? I'm not sure who else to ping, as there hasn't been much activity in this repo in about 4 months.
Related, does this repo need more maintainers?
Hi @dereknola, I think this repo desperately needs more maintainers. Currently no PR can be submitted (at least normally) because CI is broken (so there is little sense in reviewing your PR before resolving this). If you have the capacity to look at https://github.com/kubernetes/dns/issues/646, it would be really great.
Looks like the 5s timeout I added in the last PR is still not quite enough to prevent flaky e2e tests. Might consider bumping it to 10s.
@kl52752 Could you review this please? I will squash these commits, I just was waiting for review readability.
@DamianSawicki any chance you will have time this week to review this PR? I would love to pull this in to RKE2 November patches.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: DamianSawicki, dereknola, kl52752, VestigeJ
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [kl52752]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@DamianSawicki or whoever will be tagging a release: please note that coredns v1.11 renamed prometheus metrics https://github.com/coredns/coredns/blob/v1.11.0/plugin/forward/README.md#metrics with very little fanfare in release notes https://github.com/coredns/coredns/blob/v1.11.0/notes/coredns-1.11.0.md ("Some changes to forward plugin metrics.") and I believe this should be mentioned more.
How can I tell which version will have this update?
new version has not be released yet.
@anokun7 There is a new version https://github.com/kubernetes/dns/releases/tag/1.24.0 ready and in fact already https://github.com/kubernetes/dns/releases/tag/1.24.1 is being prepared.