Mikel Blanchard
Mikel Blanchard
@vishweshbankwar Hey I think this PR might have broken stuff. I'm testing the AspNetCore instrumentation using the example app. Not seeing _any_ spans when running in net6.0. Took me a...
@tillig I just ran the tests above on my branch with https://github.com/open-telemetry/opentelemetry-dotnet/pull/3780 and they all pass now! I'm going to close this issue. Feel free to do your own testing...
I'll take a stab at what `DiagnosticSource` integration might look like if no one objects. But I have a bit of a backlog so it might not be for a...
@mhowlett The one big challenge I can foresee is the trace context. When producing a message, we would spin up an Activity. When consuming a message, we need to spin...
@mhowlett I threw up PR #1278 with the Producer side of things so you could check it out. DiagnosticSource generally implements very cleanly, meaning it doesn't add a whole lot...
@ElectricVampire I just closed it. Better to do it using [ActivitySource](https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.activitysource?view=net-5.0) now. That was released with .NET 5, but is actually supported all the way back to .NET 4.5 using...
Thanks for this @fedeoliv! I did a quick review and left some comments about where we are with the spec, etc. Happy to help out however I can.
Sorry @verdysh there isn't a way to append app to the namespaces automatically. The options you have: 1. Use separate ApplicationInsights resources. That will generate a unique scope for each...
@cijothomas If we define a TelemetryInitializer and add the app name as a custom property on all the emitted telemetry would that allow us to filter/group as if it were...
@alanwest I could live with "Shim" but I think "Adapter" could also work. In the case of Serilog & EventSource, maybe even "Appender" since the spec has run with that...