Mikel Blanchard

Results 186 comments of Mikel Blanchard

> (I also haven't tried this from a usage perspective. It may be that as a constructor parameter it's not the best; but I also wonder if having the constructor...

Just FYI from the perspective of LogEmitter, the only thing required/guaranteed to always be there is Timestamp. Everything else is optional. I did that because I was thinking about the...

This conversation is pulling in a few different directions, I'll try to reply generally. * RE: removing CategoryName. I think this is good to do on `LogRecordData` which will effectively...

I was on the log SIG this week. There was some discussion about what Java does. Apparently what the Processor gets is a read/write interface to the data (span, log,...

> Do you see benefit of having such difference besides preventing accidental modification from the exporter? We have seen users use reflection to get around things being read-only so my...

@ViktorHofer Thanks for jumping in on this! I totally understand the reasoning behind the change. I support the goals fully because as a maintainer of OTel, I don't really want...

@adnang > Also, you can recursively call this .Configure() method with a new Action >```csharp >builder.Configure((sp, b) => b.Configure((sp2, b2) => ...)) >``` Totally supported and works fine! Code link:...

@vishweshbankwar I'm not totally following. .NET7 Activity (AspNetCore) should be started through a source: https://github.com/dotnet/aspnetcore/blob/bf3352f2422bf16fa3ca49021f0e31961ce525eb/src/Hosting/Hosting/src/Internal/HostingApplicationDiagnostics.cs#L327-L342 What will happen in that case is Activity.Source will be set automatically: https://github.com/dotnet/runtime/blob/28c56feae2f80231a30e4942f339b5b2f1c20062/src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Activity.cs#L1078 So these...

@stephenjust In your shared library couldn't you just target `net471;netstandard2.0;net5.0` and essentially forward the correct OTel API where you need it? You'll still achieve a significant amount of sharing. We...

Someone was asking about channel customization on Slack today so I messed with option 3 a bit. Seems like it could work: ```csharp public static GrpcChannel CreateChannel(this OtlpExporterOptions options) {...