Mikel Blanchard

Results 186 comments of Mikel Blanchard

@chris-smith-zocdoc So that rule is just something we carried over from the original version here: https://github.com/aspnet/Microsoft.AspNet.TelemetryCorrelation/blob/50f0acb7a0cb164d834eb91b839959a841577302/src/Microsoft.AspNet.TelemetryCorrelation/TelemetryCorrelationHttpModule.cs#L84 I don't think anyone is opposed to changing it. Could you possibly share a...

@chris-smith-zocdoc Thanks for that code, very helpful! I took it for a spin, here's my findings... It is a bit more complicated than simply removing `context.CurrentNotification == RequestNotification.ExecuteRequestHandler`. The order...

@cartersocha and I just ran into this too. In a demo we have something like... ```csharp builder.Services.AddOpenTelemetryTracing(options => { options .SetResourceBuilder(resourceBuilder) .AddSource("MyCustomSource") // Collect all traces from "MyCustomSource" //.AddAspNetCoreInstrumentation() //...

In the actual demo `AddAspNetCoreInstrumentation` is added so it actually works fine. We were just messing with it to capture some screenshots and disabled `AddAspNetCoreInstrumentation` temporarily thinking that would cause...

@Juniorlimaivd ASP.NET Core? Check out this [discussion](https://github.com/open-telemetry/opentelemetry-dotnet/discussions/3275#discussioncomment-2741476). You can create middleware which opens a scope with the contextual information and then it will push onto your logs automatically if you...

@gaurav137 How it is working above is how I would expect it to work, for better or worse 😄 Baggage behaves exactly like [HttpContext](https://github.com/dotnet/aspnetcore/blob/3ea008c80d5cc63de7f90ddfd6823b7b006251ff/src/Http/Http/src/HttpContextAccessor.cs#L38-L41). Why? Imagine some code like... 1....

> In the HttpContext implementation one is able to [reset the holder](https://github.com/dotnet/aspnetcore/blob/3ea008c80d5cc63de7f90ddfd6823b7b006251ff/src/Http/Http/src/HttpContextAccessor.cs#L33)... > > But the setter of Baggage.Current does not create a new holder instance. If "Baggage.Current = defaultBaggage;"...

@meastp I'm not totally familiar with how WCF works over REST. Do the message headers get promoted to HTTP headers? /cc @mconnew

@meastp Makes sense. Either case, client or server, I have the same problem: Need to somehow get at the transport details (http headers in this case) from the WCF API...

Thanks @meastp. So it looks like you can get at the incoming request headers through the `System.ServiceModel.Web.WebOperationContext.Current` static. If that is the case, try this... * In your server, change...