Jorge J. Perez
Jorge J. Perez
Grepping our last 30 days jobs at https://build.osrfoundation.org/job/ignition_gazebo-ci-ign-gazebo3-homebrew-amd64/ we find the following Integration tests flakily segfaulting on MacOS: ``` ignition_gazebo-ci-ign-gazebo3-homebrew-amd64|221|INTEGRATION_pose_publisher_system ignition_gazebo-ci-ign-gazebo3-homebrew-amd64|219|INTEGRATION_diff_drive_system ignition_gazebo-ci-ign-gazebo3-homebrew-amd64|219|INTEGRATION_velocity_control_system ignition_gazebo-ci-ign-gazebo3-homebrew-amd64|212|INTEGRATION_pose_publisher_system ignition_gazebo-ci-ign-gazebo3-homebrew-amd64|212|INTEGRATION_touch_plugin ignition_gazebo-ci-ign-gazebo3-homebrew-amd64|211|INTEGRATION_altimeter_system ignition_gazebo-ci-ign-gazebo3-homebrew-amd64|209|INTEGRATION_level_manager ignition_gazebo-ci-ign-gazebo3-homebrew-amd64|208|INTEGRATION_diff_drive_system ignition_gazebo-ci-ign-gazebo3-homebrew-amd64|208|INTEGRATION_level_manager ignition_gazebo-ci-ign-gazebo3-homebrew-amd64|207|INTEGRATION_network_handshake ignition_gazebo-ci-ign-gazebo3-homebrew-amd64|206|INTEGRATION_pose_publisher_system...
I think this is ready for review as it is, and we should be able to merge as it extends the features of the base distributed system implementation. I also...
I took some time testing this in my personal PC and using EC2 AWS instances. The main purpose was checking that the PR works using multiple computers, but I went...
I took some time testing with 5 instances in the AWS environment I prepared, I'm attaching the results. I also added some extra graphic tables so it's easier to see...
For reference, I'm attaching here a guide with the steps I followed to setup this PR and test it using AWS instances. [Setting up AWS cloud environment for testing Ignition’s...
I changed the testing script to delete older results by default with befd5fc. Otherwise just addressed old comments, I think this is ready to merge. PTAL @mjcarroll
`jammy` builds are failing on `UNIT_Gui_TEST` and I haven't seen this one before, could it be related to the changes made on: src/gui/QuickStartHandler.hh?
@ros-pull-request-builder retest this please
I wanted to take a closer look to the errors on Jammy and `UNIT_Gui_TEST` before approving, I'll track this internally with @Crola1702
Code from last demo is tracked up to b14ac8e. Not changing into formal PR because leaving the simulation running for some time crashes my PC. I'm investigating the cause of...