Ayoub Mabrouk

Results 9 comments of Ayoub Mabrouk

> The change from var to const can have dramatic effects, if you dont know the whole subject, please refrain from mass commits in the name of clean code. There...

> This contains changed behaviour and IMO is not more readable/cleaner Thank you for your feedback! I appreciate your thoughts on the changes. The update aimed to refine the zoom...

Hi @trullock can you please reply to this https://github.com/chartjs/chartjs-plugin-zoom/pull/833#issuecomment-2387185157 it would be more helpful.

> already added ! #6088 Hello @Abdel-Monaam-Aouini Thanks for your input on this! I went with a slightly different approach to keep things concise by calling accept.charsets(...charsets) directly, avoiding the...

> already added #6086 Hello @Abdel-Monaam-Aouini Thanks for your input on this! I went with a slightly different approach to keep things concise by calling accepts(this).encodings(...encodings) directly, avoiding the intermediate...

> Hey @Ayoub-Mabrouk! Great catch... can we include a test to prevent regressions? thanks @UlisesGascon The bug in _preferredTypeLegacy (using extension instead of ext) is hard to test indirectly because:...

> Thanks @Ayoub-Mabrouk Thanks! Also, PR [#72](https://github.com/onebeyond/systemic/pull/72) is approved and just needs your review.

> Hey @Ayoub-Mabrouk! Thanks for all the contributions you are doing in systemic too! ❤️ > > Do you think that we can update the tests to reflect this change...