Alan Sheinberg

> If it passes then it LGTM! Nice work :) I think it should... but I'll make sure to run it multiple times. Also, I'll rebase on the other PR...

> > In addition to addressing the review comments, can you post a link to the system test results with this change? It would be good to verify the impact...

> Thanks @AlanConfluent ! A few meta questions: > > 1. Seems the `streams_cooperative_rebalance_upgrade_test.py` is not included in this PR? I didn't update any of the upgrade tests just yet....

I made the change to switch some of these tests to just run with remote_kraft to minimize test run time.

I think this was the ultimate run which covered everything under streams: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/system-test-kafka-branch-builder--1661556003--AlanConfluent--updates_tests_kraft--9be74f3d1/2022-08-26--001./2022-08-26--001./report.html

@twalthr Thanks Timo for the in-depth review! I think I was able to respond to everything you mentioned, no real straggling issues. Please take another look.

I did notice that if you have some fairly complex generic hierarchy: ``` public abstract static class AsyncFuncGeneric extends AsyncFuncBase { private static final long serialVersionUID = 3L; abstract T[]...

I pushed my commit which adds more to the ability to resolve types in this manner. I haven't yet had a chance to see all of the cases ScalarFunction works...

>The only issue currently is a green build. Is the error in the Python related to your changes? I'm pretty sure it's not. I can't make any sense of it...

I have seen other PR jobs failing with identical python errors, so seems unrelated to this PR.