Alan Sheinberg

Results 28 comments of Alan Sheinberg

WRT the write timeout value utilized here: https://github.com/confluentinc/ksql/blob/master/ksqldb-rest-app/src/main/java/io/confluent/ksql/api/server/ResponseOutputStream.java#L110 This will still trigger if the client isn't actually reading the values we're sending, so your above solution will prevent the idle...

@MartijnVisser I updated the documentation. Please tell me if anything else is required to make the deadline.

Hi @HuangXingBo, I see you did the original PR for the python version. I was wondering about the reasoning for enabling this only for inner joins. I would like to...

> I have't spend too much thought on this but some pointers to verify that the rewrite is actually correct: https://stackoverflow.com/questions/55893354/predicate-pushdown-vs-on-clause We should definitely add more tests also for the...

I have put in placeholders in English on the udf page in Chinese, as I have seen for PTFs. Hopefully this is fine until there is a translation made.

> Thanks for the patch, @AlanConfluent. I made a pass and left some comments. > > Overall the patch looks good. One question is about support in batch mode. Ideally,...

> @AlanConfluent Can we push this forward to merge before feature freeze time? Sounds good. I will try to finish this ASAP. I don't think there are any big outstanding...