Amar Singh

Results 74 issues of Amar Singh

When paying out rewards, we calculate delegation reward payout in proportion to `delegation_total / total_backing_collator`. The denominator should be the sum of all counted delegations instead of the the sum...

A0-pleasereview
B7-runtimenoteworthy
D5-nicetohaveaudit⚠️

Follow ups to #1376 to finish randomness benchmarking - [x] `vrf_verification` benchmark - [ ] get `vrf_verification` weight and update on_initialize placeholder weight - [ ] `set_babe_randomness_results` inherent benchmark -...

A3-inprogress

Indexers are having trouble decoding AuthorMapping events that were removed/changed in #1407 . See the events not decoded here https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Fwss.api.moonbase.moonbeam.network#/explorer/query/6600 The tracking issue for this is MOON-1860. Is there a...

A3-inprogress

Removes initialization code for randomness pallet. Left the code commented out for posterity, if/when another project would like to use this pallet and add it to a running chain. Added...

A0-pleasereview
B7-runtimenoteworthy
D3-trivial

For jira ticket 1099, which was a feature request proposed by Henry: > There is currently no way to get the current nomination amount given a nominator and a collator,...

A3-stale
B7-runtimenoteworthy

https://github.com/paritytech/substrate/pull/4185 adds the new `StoragePrefixedMap` for enumeration and removal (implemented for map, linked_map, double_map). It also changes `ChangeSetOverlay` and `InMemory` backend to BTreeMap from HashMap.

new recipe 🍳

I've noticed that it's common for maps to initialize values as wrapped in an `Option` so that there is explicit handling of calls to storage in which the value does...

new recipe 🍳

Once the recipes are well-tested and have a nice CI setup, It would be nice to change `//` comments to doc comments `///` and generate documentation for the modules. The...

extension 🔌
tabled 🏓
ux 📚

Supercedes #1762 [notes on upstream code](https://hackmd.io/QnsqTRthTvif_btAtIVgSQ?view) Whitelist track is the fast track. The WhitelistOrigin is EitherOf. Does NOT include any Fellowship configuration

Supercedes #1762 and splits it into 2 PRs to make reviewing easier. This PR just moves the old governance config into files. The PR made against this PR #1839 adds...