Amar Singh

> Don't we have a smoke test for this ? If not please add one Adding it now. The smoke test will check that the `CollatorSnapshot.total == CollatorSnapshot.delegations.sum() + CollatorSnapshot.self_bond`...

I'm having trouble running the smoke tests that are updated in this PR cc @nbaztec Here is the command: ``` $ DEBUG=smoke:test-staking-rewards WSS_URL=wss://moonbeam-alpha.api.onfinality.io/public-ws npm run smoke-test ``` I've tried all...

Thanks @nbaztec , that was it! Output shows at least 1 instance of the bug on moonbase, probably more exist but purpose is not to collect them all, just to...

- [x] consistency test that total rewards (all blocks in previous round) are within inflation range

Newest smoke test output: ``` 1) Verify staking rewards rewards are given as expected: AssertionError: Total rewarded events did not match total expected issuance for collators + delegators: 72911764224129632453 !=...

Smoke test output now isn't as bad: ``` 1) Verify staking rewards rewards are given as expected: AssertionError: Total rewarded events did not match total expected issuance for collators +...

I'll leave this open until another PR brings it back against master. There are too many merge conflicts to make this branch worth maintaining.

I think we still need https://github.com/paritytech/cumulus/pull/1135 to read the BABE randomness from the relay state proof. We do have the proof in parachain-system storage now.

Yes, it is open -- MOON-1812 From that ticket: > randomness-collective-flip is low entropy. If we replace it, we need something similarly low entropy. Relay chain's epoch randomness is low...

> PS: I was looking into the moonbeam's implementation as a reference but I am not able to figure out where and how are those two unsatisfied trait being implemented...