Vladislav Volosnikov

Results 31 issues of Vladislav Volosnikov

## Related Issue https://github.com/Uniswap/v4-core/issues/250 ## Description of changes `#intialize` -> `#initialize`

### Describe the bug Typo in `#intialize` https://github.com/Uniswap/v4-core/blob/c019b0b3592c58271f4569da81ca1c340c004343/contracts/interfaces/IPoolManager.sol#L28 ### Expected Behavior Should be `#initialize` ### To Reproduce _No response_ ### Additional context _No response_

bug

## Description of changes The creation of the `StepComputations` structure for the swap is moved outside the main swap loop. As a result, the gas cost of initializing this structure...

## Related Issue The mulDiv function can be made slightly cheaper in terms of gas ## Description of changes The changes should remove a couple of stack operations and one...

Same change as in #4495 There is no actual need to use memory for this structure: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/9e3f4d60c581010c4a3979480e07cc7752f124cc/contracts/token/common/ERC2981.sol#L62 - [X] Tests - [X] Documentation - [X] Changeset entry (run `npx changeset...

ignore-changeset
gas optimization

Optimized access to nested mapping: avoiding the need to calculate the index of a slot in the storage several times. - [X] Tests - [X] Documentation - [X] Changeset entry...

ignore-changeset
gas optimization

Adds an additional `custom-error-domains` rule for solhint which is designed to check that custom error names match the rules specified in: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/GUIDELINES.md#solidity-conventions The rule checks that the error starts with...

ignore-changeset
CI

Implements what is mentioned in : https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4540#issuecomment-1693954128 I'm very interested in why the library relies on **non-strictly** increasing order everywhere, like here: https://github.com/OpenZeppelin/openzeppelin-contracts/blob/b2e7bab92044031a495a53b4ccc31c84137f4319/contracts/utils/structs/Checkpoints.sol#L164 Based on the descriptions of the functions,...

ignore-changeset

Closes https://github.com/OpenZeppelin/openzeppelin-contracts/issues/4331 #### PR Checklist - [ ] Tests - [ ] Documentation - [ ] Changeset entry (run `npx changeset add`)

tooling
CI

Opening issue as mentioned in https://github.com/OpenZeppelin/openzeppelin-contracts/pull/4576#discussion_r1316443220 **📝 Details** Since `InitializableStorage` is a [struct with two fields](https://github.com/OpenZeppelin/openzeppelin-contracts/blob/175b1e9e09b19f90d96b472a0e0b4ebea9a47762/contracts/proxy/utils/Initializable.sol#L65-L74) packed in one storage slot, compiler need to load this slot when writing new...

gas optimization