Vladislav Volosnikov

Results 29 comments of Vladislav Volosnikov

Using gas report with current `TransparentUpgradeableProxy` tests `TransparentUpgradeableProxy` deployment gas cost, `ProxyAdmin` is **Owable**: | Min | Max | Average | |--------|---------|----------| | 650444 | 674092 | 655546 | `TransparentUpgradeableProxy`...

> Are you sure ? My measurement say otherwize. I believe it is because `gt` is an evm opcode, but gte isn't (so its a compiled to an `lt` +...

The compiler reverses the condition (to `lt`) by swapping execution branches (Remix, assembly in compilation details) ![image](https://github.com/OpenZeppelin/openzeppelin-contracts/assets/13525908/0247099b-053c-4f67-bc91-f3938a3b6e39)

So, result with "1025" as input (Optimizer 200 runs, 0.8.20): old: 322 with gt: 298 with gte: 283

Maybe something like "must be a timestamp in the future or at the time the function is called"? Also this scenario can be simpler: the transaction can simply be included...

You are right that this is not a normal and is a rare event

> Hi, can you re-run using 2.2.1 just in case it was solved recently? Same error https://github.com/cryptoalgebra/Algebra/actions/runs/6221931514/job/16884846228#step:6:138

Also, seems like echidna exits without error after such crash

> Can you re-run using `coverage: true`? It could be that we missed part of the initialization when coverage is disabled. Isn't working https://github.com/cryptoalgebra/Algebra/actions/runs/6222060760/job/16885234762#step:6:125 I experimented locally, seems like this...