Konrad

Results 19 comments of Konrad

it's not connected to AspectMock, http://php.net/manual/en/reflectionproperty.setvalue.php

you can't remove 'final' from method AspectMock injects some code to every method (modifying the code before parsing instead of playing with inheritance) and allows you to return from methods...

you can use AspectMock to modify the fuction that is final and use phpunit mocks for everything else if you really need to delete 'final' you can look at https://github.com/Codeception/AspectMock/blob/master/src/AspectMock/Kernel.php...

@gaearon Can you have a look? In https://github.com/reactwg/react-18/discussions/2 you wrote > Does this break anything for Hooks? > If you’re using Hooks, we expect automatic batching to "just work" in...

Sadly I don't see a clear solution. We could either: * discourage using `instanceof` by deprecating `errors` export and exporting only error codes * for typescript we could export interfaces...

> _never_ use `instanceof` Documentation doesn't advice against it. What would be a point of exporting Error classes from the library in the first place if developer is forbidden from...

I made PR to improve docs Type safety of errors could be achieved by exporting functions that would serve as type-guards, like ```typescript const isUndiciError = (err: Error): err is...

@bboreham is this the way to update the changelog retroactively?

I had some custom logic when printing metrics: When a timeline/label-set was printed from a counter for the first time then I would prepend it with a 0 value with...