Zack Brown

Results 11 comments of Zack Brown

I strongly agree with this change.

@meh what do you think of this change?

@lemonli I have rebased your branch locally. Let me know if you'd like me to PR that to your repo.

https://github.com/lemonli/helm/pull/1

https://github.com/helm/helm/pull/10848 Someone check to see if I did the rebase correctly?

I can see two places where I think it changes the behavior for the better: `getHttpVersion` and `handleHttpGET`. On line 286 and 287 of `getHttpVersion`, we do this: ```c int...

That is correct. I removed that code in my project and my test is still passing: https://github.com/ztbrown/Porter/blob/scan-tests/src/http_utils.c#L10 https://github.com/ztbrown/Porter/blob/scan-tests/tests/http_utils_test/http_utils_test.c#L169

Well, this is currently breaking stuff. I'll take a look later and find out why that's happening.

Ah, this is breaking on `checkMime`. Looking into it.