Zsolt Dollenstein

UnicodeError on utf-8 encoded files on Windows

1

I tried running `flake8` on [black](https://github.com/ambv/black) on Windows, and it fails with: ``` > flake8 .\black.py Traceback (most recent call last): File "c:\program files (x86)\python36-32\Lib\runpy.py", line 193, in _run_module_as_main "__main__",...

Add a way to specify a parser stack limit

1

TODO: - [ ] documentation - [ ] change placeholder `STACK OVERFLOW` expected string to something nicer - [ ] test failure case: non integer stack limit given This PR...

Incompatible with flake8 5.0

1

``` File "/opt/hostedtoolcache/Python/3.10.5/x64/lib/python3.10/site-packages/fixit/common/flake8_compat.py", line 135, in reset arguments=self.args, AttributeError: 'Flake8CompatApplication' object has no attribute 'args' ``` That attribute was removed in https://github.com/PyCQA/flake8/commit/8d3afe40e1e8ba70418bada82608d47e61eedb8f which got released in 5.0.0

Allow files to be excluded for AddMissingHeaderRule

2

Add an option to `AddMissingHeaderRule` so some files can be exempt from it. Something like: ``` rule_config: AddMissingHeaderRule: path: pkg/*.py exclude: - pkg/uninteresting*.py header: |- # header line 1 #...

Add support for limiting the native parser to a certain Python version

1

This is required for guaranteeing correctness and safety when parsing/modifying/dumping trees for production code. Eg, when writing codemods, we want to know that if we ask to parse with 3.7...

fail on deeply nested trees

2

## Summary ## Test Plan

RemoveUnusedImports codemod incorrectly removes this

1

``` class X: import random a = [random.lol for _ in ()] ``` `random` here is used by the class body, but gets removed by the codemod. This might be...

Improve ParserSyntaxError messages for parse_expression and parse_statement

1

Raise more specific errors when a statement is passed in to `parse_expression`, or multiple statements to `parse_statement`. ``` ParserError: Failed to parse expression - found statement tokens Caused by ParserSyntaxError:...

In fact this is captured as a test case in https://github.com/instagram/libcst/blob/f36eacb1327830fad51e08084b46601cad681ae0/libcst/_nodes/tests/test_import.py#L394-L401 ``` cst.ImportFrom( module=cst.Name("foo"), names=( cst.ImportAlias(cst.Name("bar"), comma=cst.Comma()), cst.ImportAlias(cst.Name("baz"), comma=cst.Comma()), ), ) ``` This node generates `from foo import bar,baz,` which...

`AsName.name` has incorrect type annotations

3

For example it can be a `Subscript`, not just `Name | List | Tuple`. In fact I think there are two kinds of `AsName`s - the ones in imports and...