zorun

Results 147 comments of zorun

Here is a quick review: - **template feature:** the code looks unnecessarily complex and hard to understand. For instance, Flask has `render_template()`, you don't need to read the template file...

Thanks for coming back after 6 months :+1: Now I better understand what you are trying to do: - if you want to display a specific page by default, you...

I did some preliminary hacking around urllib2/requests here: https://github.com/zorun/bird-lg/tree/hacking But there were still a lot of bytes/string issues crashing most endpoints. I won't have time to work actively on this,...

Yes, this is interesting. Can you move the files to a subdirectory and add a small README, like it is done with `init/`?

That is, I'm assuming that people might use these Dockerfile on their own. Do you mean that we could publish "official" bird-lg images? If this requires Dockerfiles to be at...

I wonder how you handle configuration? Since providing Docker images would need lots of discussion, I have opened #76 to track this. We can already merge this to provide a...

This sounds possible. Code proposals are welcome, it could be done with new configuration variables (e.g. `ENABLE_IPV4` and `ENABLE_IPV6` that both default to `True`)

See #85 : it might be a good opportunity to add new options.

Review and testing is welcome! I will this open for a while because it's a somewhat big change.