Yuan

Results 9 comments of Yuan

@retpoline In first case, I can't reproduce it in current master (0535bfc3b7d5cd6fc73a7d4a6749a338fc5d7703) with ASAN. ``` ➜ git:(master) ✗ echo -ne "\x50\x35\x0a\x36\x33\x33\x32\x35\x34\x38\x20\x31\x37\x39\x0a\x36\x56\x5c" > crash.ppm ➜ git:(master) ✗ ./opj_compress -o test.j2k -i...

In second poc, It use a lot of memory and is killed by my system. ``` ➜ git:(master) ✗ ./opj_decompress -o test.png -i ./crash.j2k [INFO] Start to read j2k main...

I didn't use libefence, but I build with [AddressSanitizer](https://github.com/google/sanitizers/wiki/AddressSanitizer) and not have memory error report. In second test I found it malloc 26010160128 byte here。 (24 GB) https://github.com/uclouvain/openjpeg/blob/0535bfc3b7d5cd6fc73a7d4a6749a338fc5d7703/src/lib/openjp2/j2k.c#L10111-L10112 And numcomps...

But efence report error in posix_memalign. https://github.com/uclouvain/openjpeg/blob/0bda7188b7b545232a341f1d978b1e4feda46fc2/src/lib/openjp2/opj_malloc.c#L61 I don't think this function have any problem, this just posix normal function use to return alloc address.

@benkasminbullock I think this problem is the same as https://github.com/glennrp/libpng/issues/302. I build it with ASAN can also reproduce this problem. build : ``` CFLAGS="-fsanitize=address" ./configure ``` And I get same...

@AlexB1986 I did the same way to fix it, I modify file in venv/bin. Thanks.

> I do not like the idea to expose a new API BmValidateOption() from UefiBootManagerLib. The commit message also does not explain what "Boot####" variable error it can prevent. @niruiyu...