Kamil Schneider
Kamil Schneider
Great idea. I've already added a PR that addresses that. We can also do the same for make static objects on serverside. #3334
I can't reproduce crash on Win 10.0.19045.2364. Latest MTA Client.
I'm in favor of accepting this, but removing the `onResourceLoadStateChange` event. It's entirely pointless and unnecessary.
> Tough I did suggest simdjson I was under the impression that it has writer functionality too. > > I think just having rapidjson would be enough, having 2 JSON...
> > > Tough I did suggest simdjson I was under the impression that it has writer functionality too. > > > I think just having rapidjson would be enough,...
I'm closing the draft, so feel free to review. :) PR was compiled and tested on `Windows 10 x64` and `Linux Debian 11 (ARM64)`.
> > I'd advocate moving rapidjson to a submodule > > > > It looks like an universal way to make dependency. I like this idea > > Pros: >...
I’m aware that reviewing such a pull request with attached sources can be problematic and challenging to preview. I’ll try to move rapidjson to submodules today if I can and...
Sure, it might be a duplicate, but I can see that the health status is updated through the packet - that's actually a good idea. My PR has been abandoned......
I have run some test cases. The event is only triggered through function setElementHealth. Generally, we would like the event to be triggered in any case of health change.