zkyTech comments

Results 14 comments of


                                            zkyTech

Codemirror2 is not refreshing properly on prop change, need to click on editor to refresh

same problem

[ZEPPELIN-5798] Add multiline sql statement support for Livy Spark SQL interpreter

I have found a new bug in this file. message data like this will fail with exception `com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected a string but was BEGIN_OBJECT at line 1 column 9...

[ZEPPELIN-5798] Add multiline sql statement support for Livy Spark SQL interpreter

> ping @zkytech What should I do next?

[ZEPPELIN-5798] Add multiline sql statement support for Livy Spark SQL interpreter

> @zkytech Have you resolved the issue in the above comment ?[#4443 (comment)](https://github.com/apache/zeppelin/pull/4443#issuecomment-1214710538) Yes, It has been fixed in this commit https://github.com/apache/zeppelin/pull/4443/commits/c31945d85dd2add9021ed072904dd254efbe1a51 The url in commit message is wrong, it...

[ZEPPELIN-5798] Add multiline sql statement support for Livy Spark SQL interpreter

> Sorry for late response @zkytech Could you retrigger the CI? ok

[ZEPPELIN-5798] Add multiline sql statement support for Livy Spark SQL interpreter

@zjffdu fixed

[ZEPPELIN-5798] Add multiline sql statement support for Livy Spark SQL interpreter

@Reamer Done

[ZEPPELIN-5798] Add multiline sql statement support for Livy Spark SQL interpreter

[Unit test](https://github.com/apache/zeppelin/blob/master/livy/src/test/java/org/apache/zeppelin/livy/LivySQLInterpreterTest.java#L193) is required to update. Because JSON number is no longer treat as string in [this place]( https://github.com/apache/zeppelin/pull/4443/files?diff=split&w=0#diff-59de70862c221847a22c9928ee8557c1f8e86e2c148def6377c8c9df7fb1f8c7R234)