Eric Zhong

[email protected]

@Uniswap NYC @Uniswap ezhong.eth

Results 12 comments of


                                            Eric Zhong

AlphaRouter.route() function returns error: Could not find a USD/WETH pool

Your USDC address on goerli is incorrect. Try using 0x07865c6e87b9f70255377e024ace6630c1eaa37f (https://goerli.etherscan.io/address/0x07865c6e87b9f70255377e024ace6630c1eaa37f) ? There should also be a GOERLI_USDC token somewhere in the repo as well. https://developers.circle.com/docs/usdc-on-testnet

Cannot find module '../types/v3/factories/IERC20Metadata__factory' or its corresponding type declarations.

Have you run `npm install && npm run build` before compiling?

Cannot read properties of undefined (reading 'recipient')

Can you link a fork of your repo where we can reproduce the issue?

Test 1155 burning outside lock

Closed by #379

Custom ERC1155 contract

Closed by #379

Allow hook storage to persist on pool no op

Thanks for opening a PR @thogard785 ! Can you make sure your commits are signed as that's a requirement for incoming PRs :)

Investigate ERC1155 Gas Costs

Closed by #379

Revamp Harmony Bridge (Horizon) frontend

Feel free to update the reward as you see fit / fair @LeoHChen @gupadhyaya

Revamp Harmony Bridge (Horizon) frontend

@givp sounds good, just posted here: https://talk.harmony.one/t/bounty-harmony-horizon-bridge-frontend-revamp/10249. Thanks!

Test suite improvements

FYI we are splitting up modifyPosition tests with work in #402 so hopefully it'll be more fine grained

1
2
›