Zhitao Pan

Results 14 comments of Zhitao Pan

We are seeing a similar crash in our app iOS release build when using the `MathExpressionConverter`, as shown by the stack trace below: ``` System.Collections.Frozen.DefaultFrozenSet`1.GSW[[CommunityToolkit.Maui.Core.MathOperator, CommunityToolkit.Maui.Core, Version=1.0.0.0, Culture=neutral, PublicKeyToken=null]].Store(FrozenSet`1 )...

@dotnet-policy-service agree

@bijington @brminnick Thanks a lot for the review and help with the support on macOS! Sorry I haven't got the chance to look at the comments earlier, but I guess...

@brminnick @bijington Thanks for all the great work! There has been definitely great progress and the code looks much more organized and consistent to the rest of the toolkit now....

As mentioned in https://github.com/CommunityToolkit/Maui/pull/1758, the foundation of this PR is based on https://github.com/CommunityToolkit/Maui/pull/1080, where `IsTorchOn` was initially added. However, this property has not actually been implemented in any of the...

@jfversluis No worries and thanks for catching this! I completely forgot about these unimplemented features in the PR and just let them sneak in to the release... I guess the...

Hi @bijington, could this PR be assigned for review soon? As mentioned in https://github.com/CommunityToolkit/Maui/pull/2634#issuecomment-3071604323, the branch has been tested that it does solve the original crash issue.

Hi @bijington, I've addressed some of your comments and provide explanation for others, could you please take a look again? Thanks!

@TheCodeTraveler Thanks for the review and code update! I have raised a PR to update the documentation: https://github.com/MicrosoftDocs/CommunityToolkit/pull/593

Hi @bijington @TheCodeTraveler, is there any update to the status of this PR?