zhaojiangbin

Results 28 comments of zhaojiangbin

> Have you filed papers with the FSF? I just sent FSF the email to request the assignment form.

@justbur I have got the paper work done. FSF sent me the fully signed PDF. What's next?

Sorry for having been MIA. Occupied by work. > I've asked Jonas whether we should use magit-popup or wait for transient to mature (assuming IIUC and it's the intended future...

By "foreign", I meant that hydra has a different "look and feel" than the magit UI, say, magit-popup. Otherwise I am sure hydra will be capable of doing all things...

> However, when we move the regexp creation to the scan invocations, this probably won't matter anymore. So I'd suggest leaving this until that change is made. Sounds good.

Still happening in master f7c2b2da1b0480f425db8fac332c6aaacb499848. It appears that `use-package` expands a `:custom` keyword into a `customize-set-varaible` call before `require 'magit-todos`. The `:config` keyword, in comparison, is expanded into a `progn`...

This is what the README of 'use-package' says about `:custom` (emphasis mine): > NOTE: These are only for people who wish to keep customizations with their accompanying use-package declarations. Functionally,...

You're right. I must have forgotten the case where the hl-todo package is installed but not enabled. Now I have tested it. Restoring sessions isn't affected. As for fontifying the...

Pressed the wrong key in previous comment. It's zhaojiangbin/magit-todos@4e5b94edbf5f5ad9421ed579fb1be04fcf31be0c. Also, feel free to close this issue as it's working fine for me without any code change.

Hmm, there is actually another case, minor albeit. Now that I don't enable hl-todo. I customize `magit-todos-keywords` as a list of strings. If I have a new keyword that's not...