John Flatness

Results 292 comments of John Flatness

I'm a little curious as to why you want to remove the base class, given that a theme author could just remove/alter the resource-link styles if the styling is at...

I have a concern with this PR: I'm not sure we want to be providing these "o-icon" aliases for icons we're not actually using. Modules can of course use any...

This is the first I'd actually looked into PSR-3, I didn't realize it specifies a placeholder/interpolation system. It's definitely not in any current plans but I'm not opposed to the...

There was a failure on the CI but that looks to me like it was a random unrelated issue; I'll have it re-run. Not sure about the implementation detail here...

My only concern here is it seems that the URL specified would be able to override the engine, which feels like a pretty forseeable trouble point.

My concern wasn't so much for security but just support, as a pretty accessible footgun potentially. It's not necessarily a big problem just because only a certain subset of users...

Yeah, that's strange. I know there's code for only rendering the boxes for things you actually have the ability to edit, which implies that the "batch" control would be there...

I _believe_ there's also already a provision for the "batch all" to skip things you don't have permission for also, leading me to think the way to go here is...

In what context? Many of the blocks just do thumbnails and this is more or less what we'd expect them to do in this situation. There should be a _way_...

Hmmmm, I think it should be showing in the "Showcase". Browse I'd expect just the thumbnail. We could try to do something with the default thumbnail for HTML specifically also...