zenador
zenador
A few questions: 1. the util package previously didn't import anything from within mimir, but now it has to as it needs globalerrors at least. it also needs to import...
Thanks! Switched to copy/paste and 2 different methods
### commits in order, earliest to latest [before.txt](https://github.com/prometheus/prometheus/files/9859321/before.txt): f1a3dbb (prometheus:main) [after_orig.txt](https://github.com/prometheus/prometheus/files/9859322/after_orig.txt): f374523 Experiment to optimize most common aggregations + Update from rebase [after_todo.txt](https://github.com/prometheus/prometheus/files/9859323/after_todo.txt): 88e4b1d Simplify the code to expect only...
Thank you for the great work @LeviHarrison ! Closing this as it has been rebased on top of main and is to be continued in https://github.com/grafana/mimir/pull/3505
Flaked on https://github.com/prometheus/prometheus/actions/runs/8080900355/job/22078272296?pr=13662 (windows) ``` === RUN TestAsyncRuleEvaluation/asynchronous_evaluation_with_independent_and_dependent_rules manager_test.go:1926: Error Trace: D:/a/prometheus/prometheus/rules/manager_test.go:1926 Error: "0.0411435" is not less than "0.04" Test: TestAsyncRuleEvaluation/asynchronous_evaluation_with_independent_and_dependent_rules ``` and https://github.com/prometheus/prometheus/actions/runs/8153560332/job/22285206086?pr=13706 (windows) ``` === RUN TestAsyncRuleEvaluation/asynchronous_evaluation_of_all_independent_rules,_sufficient_concurrency manager_test.go:2000:...
This has been split into smaller PRs and is not needed any more
@beorn7 I will fix the test errors soon (but the build works, you can test the warnings with `quantile(3, up)`), but meanwhile please have a look to see if this...
@beorn7 Updated according to your comments, but still not sure how to add position info. For example, look at how we add the warning for invalid quantile in https://github.com/prometheus/prometheus/blob/f22466d167f28e3fac5ab9bc95a9c42bc7ed8fd2/promql/functions.go#L642 ,...
Now it looks like `PromQL warning: quantile value should be between 0 and 1, not 50.00 (at 19:21)`. Only implemented for the quantile warning as the rest aren't directly related...
@beorn7 Since we're still waiting on a decision for the API, I tried to add the position info like you suggested, now the warnings look like: PromQL warning: quantile value...