Zemian Deng comments

Results 24 comments of


                                            Zemian Deng

Add option to specify prest.toml file location

Oh, that's good to know. I didn't see this in the doc tough: https://postgres.rest/configurations/ It would be good to see that there. BTW, it maybe just me, but passing config...

Custom Controller Documentation

I have a more simpler example here that might be good to add to the README doc. I suggest keep it short. Right now, it doesn't even mention users can...

fix: use loginTimeout in java.sql.DriverManager by default

Hi Vlsi, yeah testing this is little difficult since I dont' see the PG conn properties being saved anywhere after the conn object is made. I did however did a...

fix: use loginTimeout in java.sql.DriverManager by default

@jorsol Current Driver.java code check timeout value with "

fix: use loginTimeout in java.sql.DriverManager by default

@vlsi The latest commit should addressed your concerns. Let me know what you think.

fix: use loginTimeout in java.sql.DriverManager by default

Hm... I am not sure I understand the reason for failed checks here on the last commit, which only has a javadoc misspelled word! If there is anything I can...

fix: use loginTimeout in java.sql.DriverManager by default

@vlsi, after some testing, I noticed one odd behavior with `PGProperty.isPrensent()` checks. Due to the way `Driver.connect(url, info)` is using the "info" input parameter as `java.util.Properties#defaults` only, the `PGProperty.isPrensent() `...

fix: use loginTimeout in java.sql.DriverManager by default

I now have the PGProperty.isPresent check problem fixed. I also found an existing LoginTimeoutTest that I added couple use cases there. Please review and let me know if these are...

fix: use loginTimeout in java.sql.DriverManager by default

1) Hi @vlsi i, sorry for the long delay update to this PR. I read your comments and to the post on mailing list as well. I agree that loading...

fix: use loginTimeout in java.sql.DriverManager by default

Hi @vlsi , I have put in a change that addressed your concerns now. Please review As far as test assertions. I have done similar to your existing LoginTimeoutTest, which...