Josef Eisl

Results 15 comments of Josef Eisl

hi @oraluben! See here the first of many JDK 19 PRs (#4692). It only fixes compiling and only for the /substratevm suite. There is also work in progress on the...

#81 is already a great improvement, thanks @tkrodriguez. I'd still like a flag that uses the specified upstream repo (maybe `--upstream`?). I will look into it.

@jerboaa there have been no JDK 23+19 and JDK 23+20 EA builds from https://jdk.java.net/23/, so we could also not update LabsJDK. But now things should be back at the normal...

> I'm not sure if its better to annotate each individual method, or simply the whole class. I guess it depends. Individual methods give us higher granularity, so if only...

@jerboaa @zakkak please have a look. If I'm informed correctly, you discussed this already with @christianhaeubl some time ago so there should be no big surprises. That said, please let...

@jerboaa thanks for the feedback and thanks for raising you concerns. Let me try to address them: > * It adds ~20k lines of code which is to a large...

> Have you considered using http://libcg.sourceforge.net? TBH, no. In general, external libraries need to be thoroughly reviewed and approved (compatible licenses, security reviews, etc.) and we need to track their...

> Kind of as a proof-of-concept, I'll prepare a PR which resyncs the current hotspot code. (Don't expect anything the next two weeks as it is JDK branch-off time and...

This was merged a few weeks ago and with #9250 in place, keeping the code up to date with the JDK worked out smoothly so far. That said, we still...