Emanuel Danci

icon indicating an email [email protected]

Results 16 issues of Emanuel Danci

Properly implement the reactivate subscription state transition

bug
could

Factor out the common code from {Invoice, Proforma}Serializer.

1 comment

could
cleanup
good first issue

Add translations

1 comment

enhancement
could

Allow cancel `now` if a subscription was previously canceled at `end_of_billing_cycle`

Check https://github.com/PressLabs/silver/blob/master/silver/api/views.py#L186

bug
design
must

Add validity date for proformas

How many days will the proforma be valid after being issued.

design
could
good first issue

Rename, don't delete PDFs once the invoices/proformas are issued

1 comment

Once an invoice/proforma is issued, don't delete its corresponding PDF, just rename it to something like `INV...-deleted.pdf`. This will prevent complete data loss if an invoice/proforma is deleted by mistake.

enhancement
design
should

Add endpoint for ending a subscription

design
should
good first issue

Use DateTimeField for fine-grained control on subscription-related and billing dates

design
should

Document the cases when a subscription should be billed

1 comment

Add the details about the states of the subscriptions that should be billed. It will make it easier to change the code and the tests if the cases are clearly...

enhancement
docs
design
should

Tests the dates of the doc entries, not just the values

Right now most of the tests for the `docs_generator` command check only the values of the document entries. The tests should check the dates of the entries too.

could
good first issue