Zak Stam
Zak Stam
Looking at the structure of your project and the complexity of it i'm pretty sure C# would be a better fit for it! I will see if i can help...
> I like the proposal. For `initial_value` I assume will be set the same property you're trying to animate, right? > > For the BUGS things might be a bit...
Alright this finaly seems to be working:  @Calinou ! Just as a reminder, all this PR does is adding the Url parameter for the LinkButton. This is...
~~The errors in the editor after closing the project seem to be related to `OS::get_singleton()->shell_open(url);`.~~ ``` ERROR: Condition "!process_map->has(p_pid)" is true. Returning: FAILED at: OS_Windows::kill (platform\windows\os_windows.cpp:489) ``` **EDIT:** NVM, i...
> > This is useful when you want to add link buttons through code (simplifies things) > > You mean like > > ``` > var link = LinkButton.new() >...
> var link = LinkButton.new() > link.connect("pressed", OS, "shell_open", ["https://godotengine.org/"]) Btw that's cool! If its that simple to do it (never though of this!) then we could just document it...
> > You think i should remove the connection with pressed signal? > > The problem I see is that `open_url` throws an error if url is empty, so this...
The latest commit only connects the signal if Url parameter is empty.
> This won't work (you can test it yourself). The error is mostly useful when using `open_url()` directly, so you can just bind another method under this name that would...
> > Looks ok functionality-wise. > > Docs for `url` member might need some changes though. > > I'm still not 100% convinced that this PR is useful (especially seeing...