Gyula Zakor

Results 38 comments of Gyula Zakor

@kvark I've started addressing your comments but I'm a little far from what you described at the top of the review. After I've finished addressing those comments I will answer...

I have updated our WR and tried it with a newer version of gecko and started to take a look at the layout tests (the repo: https://github.com/zakorgy/gecko-dev/tree/gecko_wr_linux_vulkan), and compared it...

I have checked the unexpected passes, and they are actual passes.

I have checked the first section of different tests (fail with the original and passes with our WR), and found that the first two passes if I run them one...

We managed to build with metal (10.13 SDK) without the black screen. Here is an image from Wikipedia: ![capture1](https://user-images.githubusercontent.com/11725775/46669996-428de900-cbd1-11e8-899f-9c8f348ceb1d.PNG) As you can see the text is wrong. We captured this...

Increasing the frame count (previously it was 1) and resetting the fence we used for freeing images produces a much better result with metal: ![screenshot 2018-10-10 at 16 04 55](https://user-images.githubusercontent.com/11725775/46743195-cf57a600-cca8-11e8-9b74-197bc87c99e3.png)...

Finally got reftest results on MacOS with Metal: ``` REFTEST INFO | Result summary: REFTEST INFO | Successful: 17999 (17970 pass, 29 load only) REFTEST INFO | Unexpected: 1007 (913...

Just a note for the above comment: The 5 crashing test is related to external textures, and https://github.com/szeged/webrender/pull/230 fixes those crashes.

@zbraniecki that was an unfortunate mistake, I've updated the numbers for `37c8ee2`. Thanks for noticing it.

I started to take a look at this, but still have some things to figure out: - Some WR feature(dual source belnding, dithering, color target) are used in the global...