Tomas Zaicevas
Tomas Zaicevas
I started looking at this. A couple of questions: > we need check that initial assigned value don't have sideeffect. In other words - whether the initially assigned value is...
cc @Belco90
> Do you have a TypeScript codebase? Yes > can you confirm that v2.25.4 (which contains #2341) has the same speed drop? Yes: ``` Rule | Time (ms) | Relative...
> Are you able to share a small reproduction of the issue @zaicevas? Sorry, won't be able to do that due to lack of time. `tsconfig.json`: ``` { "compilerOptions": {...
2.22.1 -> 2.24.2 is also a significant performance downgrade: 2.22.1: ``` import/no-cycle | 15407.126 | 6.1% ``` 2.24.2: ``` import/no-cycle | 70428.732 | 36.3% ```
It turns out that `2.24.2` does not report `import/no-cycle` violations at all 😕 ``` // a.ts import './b' export function ab() { // } // b.ts import { ab }...
> I don't think the 2nd case you exposed would be in the scope of this rule. queryBy* + presence matcher is already reported by prefer-presence-queries Fair point. > reporting...
Note that, as of now, `role` queries are incredibly slow for larger DOM trees (see https://github.com/testing-library/dom-testing-library/issues/552). Test ids is one of the ways to mitigate this. In my experience, certain...
I'll try to evaluate the complexity and let you know :)
Apologies for late answer, but I don't have capacity right now.