Zachary Mulgrew comments

Results 11 comments of


                                            Zachary Mulgrew

propEqual should treat TypedArray as arrays

Unfortunately I don't believe there is a convenient way to check `TypedArray`-ness unless you check `instanceof` for all of the various subclasses. Supporting this would be quite helpful for some...

propEqual should treat TypedArray as arrays

Are there any concerns about adding TypedArray support for browsers that don't support TypedArrays (basically IE before IE 10)?

We `preprocessTree('css')` twice.

> Unfortunately, relying on such undefined behavior has this risk It's not that my work relies on this as much as it works around it. `preprocessTree` is a public hook...

HTMLBars AST does not push CommentStatements?

The more I think about this it actually seems like not a bug. If the objective of HTMLBars' parsing is to produce an AST that ultimately maps to DOM, then...

Restore `LongHashFunction.xx_r39()` to allow consumers to migrate to `xx()`

@peter-lawrey Any chance you're be open to merging this change?

Restore `LongHashFunction.xx_r39()` to allow consumers to migrate to `xx()`

Trying @peter-lawrey-admin to see if this is an acceptable request.

Restore `LongHashFunction.xx_r39()` to allow consumers to migrate to `xx()`

@tgd Thanks for the reply. Yes, landing this change will still unblock me. I've signed the CLA now.

Pruning of nodes through plugins / Walker

Understood. This is something I would be interested in helping with for sure. At first I thought I could just use the AST Visitor from Handlebars but it turns out...

Running a unit test with code coverage enabled does not generate data in coverage.csv

Yeah, I was surprised by this myself to find that the generated `coverage.csv` contained only headings and no data.

Update zero-allocation-hashing and xx hash method name

I think this is going to be a breaking change, or at least require a lot of spot fixing when it re-enters the internal LinkedIn ecosystem. If you check internal...