Zach Borboa
Zach Borboa
related https://github.com/celery/django-celery/issues/335 https://github.com/celery/celery/issues/2174
I was also hoping the project's description `Old Celery integration project for Django` would be updated to something like `Optional Celery integration project for Django`.
Linking to GitHub source files would be really helpful. I've found myself missing this feature. We could change the "[source]" links and have them point directly to the GitHub source...
> Not yet fixed. Couldn't find a "View on GitHub" link to view the corresponding source file on GitHub. @zachborboa you're right. I reopened this issue. Would you try to...
> Would you try to propose a PR to fix this? Thanks for reopening. Will work on one
Right now we have ``` php $curl = new Curl(); $curl->get($url, $data); if ($curl->error) { // Handle error. } else { // Handle response. } ``` What would you like...
Try/Catch For: - Keeps error-handling code separate - Handling different error types - Cascading exceptions - Handle errors with user-defined error handler (`set_error_handler()`)
Try/Catch Against: - Slower (but does not add significant overhead) - Backwards compatible
Ideas for exceptions http://docs.guzzlephp.org/en/latest/quickstart.html#exceptions https://github.com/guzzle/guzzle/tree/master/src/Exception
A backwards-compatible version could look like this: ``` php $curl = new Curl(); $curl->get($url, $data); try { $curl->catch(); } catch (CurlException $e) { // Handle error. MyErrorLogger::log($e->getMessage()) } ```