zhangbo

hi, there is a bug in function MQTTClient_createWithOptions(), file "MQTTClient.c", as the following. please don't call Thread_unlock_mutex() if Thread_lock_mutex() failed. ``` FUNC_ENTRY; if ((rc = Thread_lock_mutex(mqttclient_mutex)) != 0) goto exit;...

Is there any race between original thread and new thread for callback calling?

2

hi, sometimes I got a crash in MQTT internal function connectionLost_call( ) when network fails or timeouts. I just read the related code and find out that MQTT creates a...

[bad] throw in ctor if TCP port is already occupied

4

If TCP port is already occupied, the constructor of "crow::Server" will throw exception by bind() of boost:asio(I'm using boost::asio). It's a bad practice to throw in ctor. Please refer to...

please remove the dllexport of static libs

1

hi, Currently uWebSockets and its dependency "uSockets" define a macro "WIN32_EXPORT" in header file "libusockets.h", as the following. So all uSockets api functions and a uWebSockets class named "struct WIN32_EXPORT...

Some culpp options should be defined as this

1

current definitions of curlpp options: ``` typedef curlpp::OptionTrait CaInfo; typedef curlpp::OptionTrait CaPath; typedef curlpp::OptionTrait SslCtxFunction; ``` But the above is not working if we want to use our own certificates...

At the very end of _tmain() in yara cli, there is the following line: `args_free(options);` Here is the body of args_free(): ``` void args_free(args_option_t* options) { for (; options->type !=...

in CMakeLists.txt: INCLUDE_DIRECTORIES(${EXPAT_INCLUDE_DIRS}) should be: INCLUDE_DIRECTORIES(${EXPAT_INCLUDE_DIR})

The new version of mitm proxy has changed a lot. Here is the modified version of "js-mitm-proxy\src\inject_script.py" file for it(with hard-coded js file path): ``` from mitmproxy import ctx from...

Podofo build problems with GCC 8.x

2

hello, Podofo 0.11.0 can't be built with gcc 13.2.0 on "UnionTech OS GNU/Linux 20". Here are some advices to get it built. Tested ok. 1. Optionally remove "-Wno-unknown-warning-option" from CMAKE_CXX_FLAGS...