Andrew Zhang
Andrew Zhang
Hi @fryz 👋 , this PR looks good and makes sense to me. I am not too familiar with the network check, but when you have it collect all conntrack...
Also I just noticed that since this was originally my PR, I can only comment on the PR.
@alopezz > It looks to me like it's the versions without the .count that need clarifying? ~~True, I think saying `The number of...` in the description can make it seem...
Merging because this validations issue is due to the new `packaging` dependency being added. This is fixed here: https://github.com/DataDog/integrations-core/pull/12753
For the failing Windows CI, it's likely due to some generated filenames (like the .link files) being too long. Apparently this has happened before, although the solution was to change...
> I will squash commits once a review is done (they can pollute Git history). Other review comments were addressed. PTAL. No need, the `integrations-core` repo is configured to automatically...
@nascowe bump on Celene's comment, otherwise looks good on our side.
Closing in favor of https://github.com/DataDog/integrations-core/pull/12811
Also I just added a `changelog/Added` label since it seems to be compatible with the previous version of the check. Feel free to change this to `changelog/Changed` if that is...
Closing since this is outdated