Hans Yu

Results 20 comments of Hans Yu

A number of challenges here: * When pasting HTML, how do we know when to flatten the structure? * How can we map HTML tags to component types in Taleweaver,...

I think using marks would be a cleaner approach, as it separates presentational concerns from the content and keeps the content in a simple form. I believe this is how...

Each editor element type supports its own set of attributes, so things like line height and spacing between lines can be implemented as attributes on the paragraph element. I don't...

Hey! Thanks for your interest, it might be good to hold off for a bit before contributing, as I'm currently doing a major refactor to improve various elements of the...

@MuhammedAlkhudiry Don't worry, React is not a dependency, it's just used to conveniently setup a demo / development environment. The dependencies are listed here: https://github.com/yuzhenmi/taleweaver/blob/master/packages/core/package.json As you can see, the...

Had a bit of a hiccup, but should be able to get it out this weekend. Sorry about the delay.

Yeah, definitely taking a lot longer than I expected, still recovering existing features before the refactor and fixing bugs. Overall I'm pretty happy with the design improvements though. Won't make...

> this line > const font = textStyle.font!; > > I think you want: > const font = textStyle.fontFamily!; > > since font return shorthand font properties. Note `textStyle` is...

I've merged the refactor https://github.com/yuzhenmi/taleweaver/pull/81. I'm sure there are bugs and regressions, will work through and fix them.

I'll add it to the README later. You'll have to first go to `packages/core`, run `npm install` and `npm run dev`, this starts a dev server that builds the editor...