Yahor Yuzefovich comments

Results 88 comments of


                                            Yahor Yuzefovich

opt: project required ordering for EXPLAIN to input columns

Let's merge this to fix the sqlsmith failures. bors r=mgartner,yuzefovich

roachprod: fix `roachprod init`.

I think this change might have had an unintended side effect - we no longer set the test license, which causes failures like #88665.

sql: internal error: lookup join with no lookup columns

Is there some easy way to adjust `check_expr.go` to not fire until this issue is fixed so that #58089 could be resolved?

sql: retry validation of unique constraint

I agree, it does look like the import is doing the check-pointing, but there are other users of `validateUniqueConstraint` which might not - e.g. it is used at the end...

sql: retry validation of unique constraint

TFTRs! bors r+

sql: retry validation of unique constraint

blathers backport 22.2

Provide E2E SQL and/or KV latency & error rate time-series metrics that indicate issues with CRDB rather than poor workload given cluster provisioning

cc @vy-ton

persistedsqlstats: speed up a test

TFTR! bors r+

persistedsqlstats: speed up a test

No need to backport this to 22.1 since the relevant changes from #86404 were not backported there.

pkg/sql/logictest/tests/fakedist-vec-off/fakedist-vec-off_test: TestLogic_enums failed

This one is a panic with an enum when serializing the session: ``` [08:00:48][Run stress] === RUN TestLogic_enums/regression_63138 [08:00:48][Run stress] panic: runtime error: invalid memory address or nil pointer dereference...