yuvalp-k2view

Good idea, this did actually work. Cannot turn strict mode on but that’s fine. Another issue is if my code has inner functions, it’s losing the scope. I could live...

Given the sqlite limitation, I believe this should revert to "VARCHAR" as was in previous versions. Right now we are still returning bad information, extracted from the setObject() call. So...

Testing the postgres jdbc driver, I can confirm (unexpectedly) that it is indeed a hybrid behaviour. The following test passes: ```java execute(c, "CREATE TABLE A_TABLE (a_text text, a_number numeric)"); try...

Since sqlite is extremely flexible in converting strings to its supported types, my vote still goes to VARCHAR

20-40 percent is quite huge so I think it's worth some consideration. A few suggestions: 1) Simplest - perhaps a way to turn it off using a private SqliteConnection API...

> > 20-40 percent is quite huge so I think it's worth some consideration. > > can you maybe share details on how you measured that, and against which version...

> > * A bit vague but makes sense - Use the executeBatch API as a way to signal that we are in high performance and there is no need...

So... it's actually more than double (I made a simple benchmark that had fewer columns and fewer indices so the getrowid is more pronounced). The fact that the feature was...

``` import java.io.File; import java.sql.*; public class SimpleSqliteBenchmark { public static void main(String[] args) throws SQLException { String file = "benchmark.db"; int transactions = 1000; int rowsInTx = 10_000; try...

I also tested a version where I call getGeneratedKeys in the benchmark code by adding the following after update: ``` try (ResultSet rs = ps.getGeneratedKeys()) { rs.next(); total += rs.getInt(1);...